Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

[proof chunk] [WIP] [testing] fix various issue found in integration test #1773

Merged
merged 16 commits into from
Mar 1, 2024
Merged

[proof chunk] [WIP] [testing] fix various issue found in integration test #1773

merged 16 commits into from
Mar 1, 2024

Conversation

hero78119
Copy link
Member

@hero78119 hero78119 commented Feb 21, 2024 •
edited
Loading

Content

Reported issues found on multi-chunk testing

  • refactor 1: simply chunking boundary judgement logic in bus-mapping to ready for finish other incompleted features + avoid tech dept in the future
  • add uncompleted logic in bus-mapping: chronological and by-address rwtable not propagate pre-chunk last rw correctly.
  • edge case: deal with dummy chunk for real chunk less than desired chunk in circuit params
  • allow zero limb diff in state_circuit lexicoordering => we allow duplicated rw_counter in padding, and rely on permutation constraints on by-address/chronological rw_table to avoid malicious padding insert.
  • super_circuit/root_circuit tests adopt multiple chunk

Related Issue

To close #1778

@github-actions github-actions bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-integration-tests Issues related to the integration-tests workspace member labels Feb 21, 2024
@hero78119 hero78119 changed the title [proof chunk][testing] rewrite logic to support rw_table padding [proof chunk][testing] fix various issue found in integration test Feb 22, 2024
@hero78119 hero78119 changed the title [proof chunk][testing] fix various issue found in integration test [proof chunk] [WIP] [testing] fix various issue found in integration test Feb 22, 2024
@hero78119 hero78119 mentioned this pull request Feb 22, 2024
Closed
@hero78119 hero78119 force-pushed the fix_padding branch 2 times, most recently from 155e056 to cd6c843 Compare February 23, 2024 14:38
@hero78119 hero78119 force-pushed the fix_padding branch 3 times, most recently from 73604a9 to 4870080 Compare February 29, 2024 02:17
@github-actions github-actions bot added the CI Issues related to the Continuous Integration mechanisms of the repository. label Feb 29, 2024
@github-actions github-actions bot removed the CI Issues related to the Continuous Integration mechanisms of the repository. label Mar 1, 2024
@hero78119
Copy link
Member Author

All checked pass, will merge to feature branch and having the review in another PR

@hero78119 hero78119 merged commit 0ab41c9 into privacy-scaling-explorations:proof-chunk Mar 1, 2024
15 checks passed
@hero78119 hero78119 mentioned this pull request Mar 1, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
crate-bus-mapping Issues related to the bus-mapping workspace member crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-integration-tests Issues related to the integration-tests workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hero78119